[PATCH] drm: tegra: fix memory leak in error handling path
cgel.zte at gmail.com
cgel.zte at gmail.com
Tue Mar 29 10:37:47 UTC 2022
From: Lv Ruyi <lv.ruyi at zte.com.cn>
Before leave the nvdec_load_firmware, we shuold free virt which is alloced
by dma_alloc_coherent, so change "return err" to "goto cleanup".
Reported-by: Zeal Robot <zealci at zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi at zte.com.cn>
---
drivers/gpu/drm/tegra/nvdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/nvdec.c b/drivers/gpu/drm/tegra/nvdec.c
index 79e1e88203cf..a14863346bfa 100644
--- a/drivers/gpu/drm/tegra/nvdec.c
+++ b/drivers/gpu/drm/tegra/nvdec.c
@@ -209,7 +209,7 @@ static int nvdec_load_firmware(struct nvdec *nvdec)
err = dma_mapping_error(nvdec->dev, iova);
if (err < 0)
- return err;
+ goto cleanup;
} else {
virt = tegra_drm_alloc(tegra, size, &iova);
}
--
2.25.1
More information about the dri-devel
mailing list