[PATCH v2 0/4] drm/msm/dp: simplify dp_connector_get_modes()

Dmitry Baryshkov dmitry.baryshkov at linaro.org
Wed Mar 30 22:30:04 UTC 2022


As noted by Ville Syrjälä [1] the dp_connector_get_modes() has weird
on-stack interim copy of the mode. When reviewing the mentioned patch I
noticed that the rest of the code in dp_connector_get_modes() is weird,
unused since September of 2020 and can be removed. This series removes
dead weird code leaving dp_connector_get_modes() simple enough.

[1] https://lore.kernel.org/linux-arm-msm/20220218100403.7028-11-ville.syrjala@linux.intel.com/

Changes since v1:
- Remove unsued ret variable from dp_display_get_modes()
- Add a patch making dp_connector_mode_valid() return MODE_CLOCK_HIGH
  (suggested by Stephen)

Dmitry Baryshkov (4):
  drm/msm/dp: drop dp_mode argument from dp_panel_get_modes()
  drm/msm/dp: simplify dp_connector_get_modes()
  drm/msm/dp: remove max_pclk_khz field from dp_panel/dp_display
  drm/msm/dp: make dp_connector_mode_valid() more precise

 drivers/gpu/drm/msm/dp/dp_debug.c   |  2 --
 drivers/gpu/drm/msm/dp/dp_display.c | 12 +++-------
 drivers/gpu/drm/msm/dp/dp_display.h |  5 +----
 drivers/gpu/drm/msm/dp/dp_drm.c     | 35 +++--------------------------
 drivers/gpu/drm/msm/dp/dp_panel.c   |  2 +-
 drivers/gpu/drm/msm/dp/dp_panel.h   |  3 +--
 6 files changed, 9 insertions(+), 50 deletions(-)

-- 
2.35.1



More information about the dri-devel mailing list