[PATCH 1/3] drm/amdgpu/gfx10: Initalise index

[Alex Deucher]

On Wed, May 4, 2022 at 12:50 PM Mike Lothian <mike at fireburn.co.uk> wrote:
>
> This stops clang complaining:
>
> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:3846:6: warning: variable 'index' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
>         if (ring->is_mes_queue) {
>             ^~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:3903:30: note: uninitialized use occurs here
>         amdgpu_device_wb_free(adev, index);
>                                     ^~~~~
> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:3846:2: note: remove the 'if' if its condition is always false
>         if (ring->is_mes_queue) {
>         ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:3839:16: note: initialize the variable 'index' to silence this warning
>         unsigned index;
>                       ^
>                        = 0
>

Thanks for the patches.  The proper fix for patches 1 and 2 is to
protect amdgpu_device_wb_free() with if (!ring->is_mes_queue).  Care
to rework the patches that way?

Alex


> Signed-off-by: Mike Lothian <mike at fireburn.co.uk>
> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> index fc289ee54a47..7ce62b12e5b4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> @@ -3836,7 +3836,7 @@ static int gfx_v10_0_ring_test_ib(struct amdgpu_ring *ring, long timeout)
>         struct amdgpu_device *adev = ring->adev;
>         struct amdgpu_ib ib;
>         struct dma_fence *f = NULL;
> -       unsigned index;
> +       unsigned index = 0;
>         uint64_t gpu_addr;
>         volatile uint32_t *cpu_ptr;
>         long r;
> --
> 2.35.1
>