[RFC PATCH 1/1] drm/format-helper: Add KUnit tests for drm_fb_xrgb8888_to_rgb332()
jose.exposito89 at gmail.com
Mon May 30 16:29:03 UTC 2022
On Mon, May 30, 2022 at 03:11:58PM +0200, Maxime Ripard wrote:
> On Mon, May 30, 2022 at 12:20:17PM +0200, José Expósito wrote:
> > Test the conversion from XRGB8888 to RGB332.
> > What is tested?
> > - Different values for the X in XRGB8888 to make sure it is ignored
> > - Different clip values: Single pixel and full and partial buffer
> > - Well know colors: White, black, red, green, blue, magenta, yellow
> > and cyan
> > - Other colors: Randomly picked
> > - Destination pitch
> > Suggested-by: Javier Martinez Canillas <javierm at redhat.com>
> > Signed-off-by: José Expósito <jose.exposito89 at gmail.com>
> It looks mostly good to me, but I think we should Cc
> kunit-dev at googlegroups.com to have their feedback.
Thanks a lot for the quick feedback.
I just cc'ed kunit-dev at googlegroups.com. For anyone joining the
conversation, here is the link to the patch and the cover letter with
> > ---
> > drivers/gpu/drm/Kconfig | 12 ++
> > drivers/gpu/drm/Makefile | 3 +
> > drivers/gpu/drm/drm_format_helper_test.c | 166 +++++++++++++++++++++++
> > 3 files changed, 181 insertions(+)
> > create mode 100644 drivers/gpu/drm/drm_format_helper_test.c
> > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> > index e88c497fa010..d92be6faef15 100644
> > --- a/drivers/gpu/drm/Kconfig
> > +++ b/drivers/gpu/drm/Kconfig
> > @@ -76,6 +76,18 @@ config DRM_KMS_HELPER
> > help
> > CRTC helpers for KMS drivers.
> > +config DRM_FORMAR_HELPER_TEST
> > + bool "drm_format_helper tests" if !KUNIT_ALL_TESTS
> > + depends on DRM && KUNIT=y
> > + select DRM_KMS_HELPER
> > + default KUNIT_ALL_TESTS
> > + help
> > + KUnit tests for the drm_format_helper APIs. This option is not
> > + useful for distributions or general kernels, but only for kernel
> > + developers working on DRM and associated drivers.
> > +
> > + If in doubt, say "N".
> > +
> AFAIK, kunit test cases are supposed to have a .kunitconfig too to
> enable the kunit tests easily.
A .kuniconfig example is present in the cover letter. My understanding
from the docs:
Is that, like the .config file, the .kunitconfig file is not meant to
be included in git, but I'm sure someone else will clarify this point.
More information about the dri-devel