[PATCH v6 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

[allen.chen at ite.com.tw]

hi

-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> 
Sent: Friday, October 28, 2022 9:59 AM
To: Allen Chen (陳柏宇) <allen.chen at ite.com.tw>
Cc: Pin-Yen Lin <treapking at chromium.org>; Jau-Chih Tseng (曾昭智) <Jau-Chih.Tseng at ite.com.tw>; Hermes Wu (吳佳宏) <Hermes.Wu at ite.com.tw>; Kenneth Hung (洪家倫) <Kenneth.Hung at ite.com.tw>; Andrzej Hajda <andrzej.hajda at intel.com>; Neil Armstrong <narmstrong at baylibre.com>; Robert Foss <robert.foss at linaro.org>; Laurent Pinchart <Laurent.pinchart at ideasonboard.com>; Jonas Karlman <jonas at kwiboo.se>; Jernej Skrabec <jernej.skrabec at gmail.com>; David Airlie <airlied at linux.ie>; Daniel Vetter <daniel at ffwll.ch>; Rob Herring <robh+dt at kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt at linaro.org>; open list:DRM DRIVERS <dri-devel at lists.freedesktop.org>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree at vger.kernel.org>; open list <linux-kernel at vger.kernel.org>
Subject: Re: [PATCH v6 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

On 26/10/2022 23:01, allen wrote:
> From: allen chen <allen.chen at ite.com.tw>
> 
> Add properties to restrict dp output data-lanes and clock.

This is a friendly reminder during the review process.

It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all requested changes or keep discussing them.

Thank you.

==> I am sorry I didn't find the missing advice you said. Could you explain it again?

Rob asked - Commit msg should explain reason for breaking users.

> 
> Signed-off-by: Pin-Yen Lin <treapking at chromium.org>
> Signed-off-by: Allen Chen <allen.chen at ite.com.tw>
> ---
>  .../bindings/display/bridge/ite,it6505.yaml   | 68 +++++++++++++++++--
>  1 file changed, 62 insertions(+), 6 deletions(-)
> 
> diff --git 
> a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml 
> b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> index 833d11b2303a7..b16a9d9127ddb 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> @@ -52,9 +52,49 @@ properties:
>      maxItems: 1
>      description: extcon specifier for the Power Delivery
>  
> -  port:
> -    $ref: /schemas/graph.yaml#/properties/port
> -    description: A port node pointing to DPI host port node
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +
> +    properties:
> +      port at 0:
> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
> +        description: A port node pointing to DPI host port node
> +
> +        properties:
> +          endpoint:
> +            $ref: /schemas/graph.yaml#/$defs/endpoint-base
> +            unevaluatedProperties: false
> +
> +            properties:
> +              link-frequencies:
> +                minItems: 1
> +                maxItems: 1
> +                description: Allowed max link frequencies in Hz
> +
> +      port at 1:
> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
> +        description: Video port for DP output
> +
> +        properties:
> +          endpoint:
> +            $ref: /schemas/graph.yaml#/$defs/endpoint-base
> +            unevaluatedProperties: false
> +
> +            properties:
> +              data-lanes:
> +                minItems: 1
> +                uniqueItems: true
> +                items:
> +                  - enum: [ 0, 1 ]
> +                  - const: 1
> +                  - const: 2
> +                  - const: 3
> +

This looks ok.

Best regards,
Krzysztof