[PATCH v2 1/2] drm/ofdrm: Convert PCI IDs to CPU endianness for comparing

Javier Martinez Canillas javierm at redhat.com
Wed Nov 2 13:28:25 UTC 2022


On 10/28/22 14:22, Thomas Zimmermann wrote:
> Properties of 32-bit integers are returned from the OF device tree
> as type __be32. Convert PCI vendor and device IDs from __be32 to host
> endianness before comparing them to constants. All relevant machines
> are old, big-endian Macintosh systems; hence the bug never happened
> in practice.
> 
> Fixes sparse warnings shown below.
> 
>   drivers/gpu/drm/tiny/ofdrm.c:237:17: warning: restricted __be32 degrades to integer
>   drivers/gpu/drm/tiny/ofdrm.c:238:18: warning: restricted __be32 degrades to integer
>   drivers/gpu/drm/tiny/ofdrm.c:238:54: warning: restricted __be32 degrades to integer
> 
> See [1] for the bug report.
> 
> v2:
> 	* convert endianness (Alex)
> 
> Reported-by: kernel test robot <lkp at intel.com>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> Link: https://lore.kernel.org/dri-devel/202210192208.D888I6X7-lkp@intel.com/ # [1]
> ---

Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



More information about the dri-devel mailing list