[PATCH v6 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

allen.chen at ite.com.tw allen.chen at ite.com.tw
Thu Nov 3 08:27:58 UTC 2022


hi

-----Original Message-----
From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> 
Sent: Thursday, November 3, 2022 12:34 AM
To: Allen Chen (陳柏宇) <allen.chen at ite.com.tw>
Cc: treapking at chromium.org; Jau-Chih Tseng (曾昭智) <Jau-Chih.Tseng at ite.com.tw>; Hermes Wu (吳佳宏) <Hermes.Wu at ite.com.tw>; Kenneth Hung (洪家倫) <Kenneth.Hung at ite.com.tw>; andrzej.hajda at intel.com; narmstrong at baylibre.com; robert.foss at linaro.org; Laurent.pinchart at ideasonboard.com; jonas at kwiboo.se; jernej.skrabec at gmail.com; airlied at linux.ie; daniel at ffwll.ch; robh+dt at kernel.org; krzysztof.kozlowski+dt at linaro.org; dri-devel at lists.freedesktop.org; devicetree at vger.kernel.org; linux-kernel at vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: it6505: add properties to restrict output bandwidth

On 02/11/2022 02:54, allen.chen at ite.com.tw wrote:
> On 26/10/2022 23:01, allen wrote:
>> From: allen chen <allen.chen at ite.com.tw>
>>
>> Add properties to restrict dp output data-lanes and clock.
> 
> This is a friendly reminder during the review process.
> 
> It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all requested changes or keep discussing them.
> 
> Thank you.
> 
> ==> I am sorry I didn't find the missing advice you said. Could you explain it again?
> 
> Rob asked - Commit msg should explain reason for breaking users.

And where is the reason? I saw only one sentence "Add properties to restrict dp output data-lanes and clock."
==> I will add the commit msg in v7. Thanks for the suggestion.

Best regards,
Krzysztof



More information about the dri-devel mailing list