[PATCH] video: fbdev: pxafb: Remove unnecessary print function dev_err()

Helge Deller deller at gmx.de
Mon Nov 7 08:52:35 UTC 2022


On 11/6/22 15:16, wangkailong at jari.cn wrote:
> Eliminate the follow coccicheck warning:
>
> ./drivers/video/fbdev/pxafb.c:2330:2-9: line 2330 is redundant because
> platform_get_irq() already prints an error
>
> Signed-off-by: KaiLong Wang <wangkailong at jari.cn>

applied.
Thanks!
Helge

> ---
>   drivers/video/fbdev/pxafb.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
> index 696ac5431180..c46ed78298ae 100644
> --- a/drivers/video/fbdev/pxafb.c
> +++ b/drivers/video/fbdev/pxafb.c
> @@ -2327,7 +2327,6 @@ static int pxafb_probe(struct platform_device *dev)
>
>   	irq = platform_get_irq(dev, 0);
>   	if (irq < 0) {
> -		dev_err(&dev->dev, "no IRQ defined\n");
>   		ret = -ENODEV;
>   		goto failed_free_mem;
>   	}



More information about the dri-devel mailing list