[PATCH v2 1/2] drm/atomic-helper: Add {begin,end}_fb_access to plane helpers

Javier Martinez Canillas javierm at redhat.com
Tue Nov 8 12:10:05 UTC 2022


Hello Thomas,

On 10/25/22 12:17, Thomas Zimmermann wrote:> Add {begin,end}_fb_access helpers to run at the beginning and end of
> an atomic commit. The begin_fb_access helper aquires resources that

acquires

> are necessary to perform the atomic commit. It it similar to prepare_fb,
> except that the resources are to be released at the end of the commit.
> Resources acquired by prepare_fb are held until after the next pageflip.
> 
> The end_fb_access helper performs the corresponding resource cleanup.
> Atomic helpers call it with the new plane state. This is differnt from

different

> cleanup_fb, which releases resources of the old plane state.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> ---

The change makes sense to me.

Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



More information about the dri-devel mailing list