[PATCH V4 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

[Linus Walleij]

Hi Chris,

thanks for your patch! The following is just nitpicks so take it or
leave it.

On Fri, Oct 28, 2022 at 10:50 PM Chris Morgan <macroalpha82 at gmail.com> wrote:

> From: Chris Morgan <macromorgan at hotmail.com>
>
> Add documentation for the NewVision NV3051D panel bindings.
> Note that for the two expected consumers of this panel binding
> the underlying LCD model is unknown. Name "anbernic,rg353p-panel"
> is used because the hardware itself is known as "anbernic,rg353p".
>
> Signed-off-by: Chris Morgan <macromorgan at hotmail.com>
(...)

> +  reset-gpios: true

I would add description: and say that this needs to be flagged
GPIO_ACTIVE_LOW since the reset signal is active low.

> +  vdd-supply: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - backlight
> +  - vdd-supply

If someone happen to just wire vdd-supply to some fixed regulator
then they don't need vdd-supply so this is a bit of a tough requirement.

Yours,
Linus Walleij