[PATCH 3/5] drm/amdgpu: stop resubmittting jobs in amdgpu_pci_resume

Alex Deucher alexdeucher at gmail.com
Thu Nov 10 19:43:42 UTC 2022


On Wed, Nov 9, 2022 at 4:50 AM Christian König
<ckoenig.leichtzumerken at gmail.com> wrote:
>
> As far as I can see this is not really recoverable since a PCI reset
> clears VRAM.

Might be more clear to say the state of VRAM is unreliable due to a
PCI event like an AER event or a link reset or DPC event.  The reset
itself may not clear VRAM directly (e.g., mode2 reset or APUs).

Alex

>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 3a51c4c61833..8564d4a8e3e8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -5747,8 +5747,6 @@ void amdgpu_pci_resume(struct pci_dev *pdev)
>                 if (!ring || !ring->sched.thread)
>                         continue;
>
> -
> -               drm_sched_resubmit_jobs(&ring->sched);
>                 drm_sched_start(&ring->sched, true);
>         }
>
> --
> 2.34.1
>


More information about the dri-devel mailing list