[PATCH 2/2] fbdev: Add support for the nomodeset kernel parameter

[Helge Deller]

On 11/11/22 12:42, Thomas Zimmermann wrote:
> Hi
>
> Am 11.11.22 um 11:49 schrieb Helge Deller:
>> On 11/11/22 10:49, Javier Martinez Canillas wrote:
>>> On 11/8/22 09:16, Thomas Zimmermann wrote:
>>>> Hi
>>>
>>> [...]
>>>
>>>>
>>>> My proposal would be to add a little helper to fbdev that includes your
>>>> suggestions:
>>>>
>>>>     bool fb_modesetting_disabled(const char *drvname)
>>>>     {
>>>>        fwonly = video_firmware_drivers_only()
>>>>        if (fbonly && drvname)
>>>>     pr_warn("")
>>>>        return fbonly;
>>>>     }
>>
>> I'm still wondering why you can't simply merge it with what is printed in
>>   [1] https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_nomodeset.c#L18
>
> I don't understand. That message is still there after moving the code
> around.

Sure.

> It is always printed if the nomodeset parameter is given.

Yes, but wouldn't it be better if it would print the name of the really affected DRM driver too?
Currently it even shows up if you don't have any graphic card installed (and gave that parameter).

> In addition to that, you get a per-driver warning for fbdev, so that it's clear which drivers are affected.

and a per-drm-driver message would be nice too (can be added by follow-up patches).

Helge

>
> Best regards
> Thomas
>
>>
>> Other than that, your the proposal is okay, if you adjust your patches to
>> call this new function "fb_modesetting_disabled()" instead of
>> calling video_firmware_drivers_only() like this:
>>
>>> +    if (video_firmware_drivers_only())
>>> +        return -ENODEV;
>>
>> Helge
>