[PATCH 2/3] drm/tests: helpers: Add module infos

[Maxime Ripard]

On Wed, Nov 16, 2022 at 01:32:51PM +0200, Jani Nikula wrote:
> On Wed, 16 Nov 2022, Maíra Canal <mairacanal at riseup.net> wrote:
> > Hi Maxime,
> >
> > On 11/16/22 06:17, Maxime Ripard wrote:
> >> The MODULE_LICENSE macro is missing from the kunit helpers file, thus
> >> leading to a build error.
> >> 
> >> Let's introduce it along with MODULE_AUTHOR.
> >> 
> >> Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers")
> >> Reported-by: Stephen Rothwell <sfr at canb.auug.org.au>
> >> Signed-off-by: Maxime Ripard <maxime at cerno.tech>
> >
> > It would be nice to add the SPDX-License-Identifier tag in the source
> > file as well. Besides that,
> 
> It's not just nice, it's basically mandatory to add license boilerplate.
> 
> Checkpatch would've warned about this. And actually about a lot of stuff
> in the series.

Right, sorry about that. I'll send additional patches to address the
issues already in.

> (And our CI checkpatch did too, although we don't send the replies to
> the world, just intel-gfx [1].)

I'm not sure how helpful it is though if the author is not a recipient
of the report

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20221116/1edf900b/attachment.sig>