[PATCH v1] dt-bindings: display: Convert fsl,imx-fb.txt to dt-schema
Philipp Zabel
p.zabel at pengutronix.de
Wed Nov 16 17:49:21 UTC 2022
On Thu, Nov 10, 2022 at 10:49:45AM +0100, Uwe Kleine-König wrote:
[...]
> new file mode 100644
> index 000000000000..c3cf6f92a766
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx-lcdc.yaml
> @@ -0,0 +1,110 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/imx/fsl,imx-lcdc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX LCD Controller, found on i.MX1, i.MX21, i.MX25 and i.MX27
> +
> +maintainers:
> + - Sascha Hauer <s.hauer at pengutronix.de>
> + - Pengutronix Kernel Team <kernel at pengutronix.de>
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - fsl,imx1-fb
> + - fsl,imx21-fb
Are the items/enum keywords superfluous here? Couldn't this just be two
- const: fsl,imx1-fb
- const: fsl,imx21-fb
entries?
> + - items:
> + - enum:
> + - fsl,imx25-fb
> + - fsl,imx27-fb
> + - const: fsl,imx21-fb
> +
> + clocks:
> + maxItems: 3
> +
> + clock-names:
> + items:
> + - const: ipg
> + - const: ahb
> + - const: per
clocks and clock-names are new, so this is a little bit more than a
straight forward conversion. I'd mention this in the commit description.
regards
Philipp
More information about the dri-devel
mailing list