[PATCH v5] drm/mediatek: Add AFBC support to Mediatek DRM driver
AngeloGioacchino Del Regno
angelogioacchino.delregno at collabora.com
Thu Nov 17 09:17:43 UTC 2022
Il 16/11/22 20:33, Justin Green ha scritto:
> From: Justin Green <greenjustin at chromium.org>
>
> Tested on MT8195 and confirmed both correct video output and improved DRAM
> bandwidth performance.
>
> v5:
> * Removed some dead defines.
> * Refactored mtk_ovl_set_afbc().
>
> v4:
> * Move modifier validation to format_mod_supported function.
> * Add modifiers to drm_universal_plane_init() call.
> * Make comparisons to DRM_FORMAT_MOD_LINEAR explicit rather than relying on
> DRM_FORMAT_LINEAR being equal to 0.
> * Gate AFBC control bit writes on device compatibility.
>
> v3:
> * Replaced pitch bitshift math with union based approach.
> * Refactored overlay register writes to shared code between non-AFBC and
> AFBC.
> * Minor code cleanups.
>
> v2:
> * Marked mtk_ovl_set_afbc as static.
> * Reflowed some lines to fit column limit.
>
> Signed-off-by: Justin Green <greenjustin at chromium.org>
Can you please move the version log to *after* the "---"?
That's not something that should actually end up being in the commit description.
After that, or if the maintainer wants to take care about removing that
while applying...:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno at collabora.com>
More information about the dri-devel
mailing list