[PATCH v2 0/7] drm: Fix the color-depth/bpp confusion
Thomas Zimmermann
tzimmermann at suse.de
Wed Nov 23 11:53:41 UTC 2022
A number of drivers mix up the meaning of bits-per-pixel and color
depth. For each of them, set the correct values. As a rule of thumb,
the color depth is the number of color and alpha bits that affect
image composition. The bpp value is the color depth in the pixel
plus the filler bits.
The color depth is exported to userspace, while the bpp value only
affects fbdev emulation. Currently, fbdev fails if it selects a color
format that is unsupported by the driver. The fix would be to fall
back to a driver default value for the bpp. Getting the default fixed
in drivers will then allow us to fix the fbdev format selection.
v2:
* leave out 15-bit color in logicvc (Javier)
* minor typos (Javier)
Thomas Zimmermann (7):
drm/hisilicon/hibmc: Fix preferred depth and bpp
drm/logicvc: Fix preferred fbdev cpp
drm/cirrus: Decouple fbdev bpp value from color depth
drm/ofdrm: Set preferred depth from format of scanout buffer
drm/simpledrm: Set preferred depth from format of scanout buffer
drm/solomon: Set preferred color depth and bpp to the correct values
drm/fb-helper: Don't use the preferred depth for the BPP default
drivers/gpu/drm/drm_fbdev_generic.c | 15 +++++++++------
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 4 ++--
drivers/gpu/drm/logicvc/logicvc_drm.c | 13 ++++++++++++-
drivers/gpu/drm/solomon/ssd130x.c | 4 ++--
drivers/gpu/drm/tiny/cirrus.c | 2 +-
drivers/gpu/drm/tiny/ofdrm.c | 13 +------------
drivers/gpu/drm/tiny/simpledrm.c | 4 ++--
7 files changed, 29 insertions(+), 26 deletions(-)
--
2.38.1
More information about the dri-devel
mailing list