[PATCH v6 3/7] dt-bindings: drm/bridge: anx7625: Add mode-switch support
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Sun Nov 27 20:58:21 UTC 2022
On 24/11/2022 11:20, Pin-yen Lin wrote:
> Analogix 7625 can be used in systems to switch the DP traffic between
> two downstreams, which can be USB Type-C DisplayPort alternate mode
> lane or regular DisplayPort output ports.
>
> Update the binding to accommodate this usage by introducing a
> data-lanes and a mode-switch property on endpoints.
>
> Also include the link to the product brief in the bindings.
>
> Signed-off-by: Pin-yen Lin <treapking at chromium.org>
>
> ---
>
> Changes in v6:
> - Remove switches node and use endpoints and data-lanes property to
> describe the connections.
Except missing testing few things...
>
> .../display/bridge/analogix,anx7625.yaml | 73 ++++++++++++++++++-
> 1 file changed, 71 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 4590186c4a0b..5fdbf1f3bab8 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -12,7 +12,8 @@ maintainers:
>
> description: |
> The ANX7625 is an ultra-low power 4K Mobile HD Transmitter
> - designed for portable devices.
> + designed for portable devices. Product brief is available at
> + https://www.analogix.com/en/system/files/AA-002291-PB-6-ANX7625_ProductBrief.pdf
>
> properties:
> compatible:
> @@ -112,10 +113,36 @@ properties:
> data-lanes: true
>
> port at 1:
> - $ref: /schemas/graph.yaml#/properties/port
> + $ref: /schemas/graph.yaml#/properties/port-base
I don't understand why you are changing this line.
> description:
> Video port for panel or connector.
>
> + patternProperties:
> + "^endpoint@[01]$":
> + $ref: /schemas/media/video-interfaces.yaml#
> + type: object
> + unevaluatedProperties: false
> +
> + properties:
> + reg:
> + maxItems: 1
> +
> + remote-endpoint: true
> +
> + data-lanes:
> + minItems: 1
> + uniqueItems: true
These are confusing... you allow only one item, so why minItems and
uniqueItems?
> + items:
> + - enum: [ 0, 1, 2, 3]
> +
> + mode-switch:
> + type: boolean
> + description: Register this node as a Type-C mode switch or not.
> +
> + required:
> + - reg
> + - remote-endpoint
> +
> required:
> - port at 0
> - port at 1
> @@ -186,3 +213,45 @@ examples:
> };
> };
> };
> + - |
> + &i2c3 {
> + anx_bridge_dp: anx7625-dp at 58 {
Messed up indentation.
> + compatible = "analogix,anx7625
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
";
> + reg = <0x58>;
Best regards,
Krzysztof
More information about the dri-devel
mailing list