[PATCH v2] drm: Only select I2C_ALGOBIT for drivers that actually need it
Thomas Zimmermann
tzimmermann at suse.de
Mon Nov 28 18:16:11 UTC 2022
Hi
Am 12.09.22 um 11:15 schrieb Uwe Kleine-König:
> While working on a drm driver that doesn't need the i2c algobit stuff I
> noticed that DRM selects this code even tough only 8 drivers actually use
> it. While also only some drivers use i2c, keep the select for I2C for the
> next cleanup patch. Still prepare this already by also selecting I2C for
> the individual drivers.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
> Changes since v1
> (20210514100142.1182997-1-u.kleine-koenig at pengutronix.de) from
> 2021-05-14:
>
> - rebased to next-20220909
> was something around v5.13-rc2 before, required to fix context
> changes in the nouveau Kconfig file. git am -3 handled it just fine.
>
> I reverified that no new drivers were added that need a corresponding
> select.
>
> Best regards
> Uwe
>
> drivers/gpu/drm/Kconfig | 5 ++++-
> drivers/gpu/drm/ast/Kconfig | 2 ++
> drivers/gpu/drm/gma500/Kconfig | 2 ++
> drivers/gpu/drm/hisilicon/hibmc/Kconfig | 2 ++
> drivers/gpu/drm/i915/Kconfig | 2 ++
> drivers/gpu/drm/mgag200/Kconfig | 2 ++
> drivers/gpu/drm/nouveau/Kconfig | 2 ++
> 7 files changed, 16 insertions(+), 1 deletion(-)
amdgpu and radeon also include <linux/i2c-algo-bit.h>. Are they special
in some way?
Best regards
Thomas
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index 198ba846d34b..593d7335b10a 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -13,7 +13,6 @@ menuconfig DRM
> select HDMI
> select FB_CMDLINE
> select I2C
> - select I2C_ALGOBIT
> select DMA_SHARED_BUFFER
> select SYNC_FILE
> # gallium uses SYS_kcmp for os_same_file_description() to de-duplicate
> @@ -231,6 +230,8 @@ config DRM_RADEON
> select DRM_KMS_HELPER
> select DRM_TTM
> select DRM_TTM_HELPER
> + select I2C
> + select I2C_ALGOBIT
> select POWER_SUPPLY
> select HWMON
> select BACKLIGHT_CLASS_DEVICE
> @@ -262,6 +263,8 @@ config DRM_AMDGPU
> select DRM_SCHED
> select DRM_TTM
> select DRM_TTM_HELPER
> + select I2C
> + select I2C_ALGOBIT
> select POWER_SUPPLY
> select HWMON
> select BACKLIGHT_CLASS_DEVICE
> diff --git a/drivers/gpu/drm/ast/Kconfig b/drivers/gpu/drm/ast/Kconfig
> index fbcf2f45cef5..bcc25decd485 100644
> --- a/drivers/gpu/drm/ast/Kconfig
> +++ b/drivers/gpu/drm/ast/Kconfig
> @@ -6,6 +6,8 @@ config DRM_AST
> select DRM_VRAM_HELPER
> select DRM_TTM
> select DRM_TTM_HELPER
> + select I2C
> + select I2C_ALGOBIT
> help
> Say yes for experimental AST GPU driver. Do not enable
> this driver without having a working -modesetting,
> diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig
> index 807b989e3c77..2efc0eb41c64 100644
> --- a/drivers/gpu/drm/gma500/Kconfig
> +++ b/drivers/gpu/drm/gma500/Kconfig
> @@ -3,6 +3,8 @@ config DRM_GMA500
> tristate "Intel GMA500/600/3600/3650 KMS Framebuffer"
> depends on DRM && PCI && X86 && MMU
> select DRM_KMS_HELPER
> + select I2C
> + select I2C_ALGOBIT
> # GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915
> select ACPI_VIDEO if ACPI
> select BACKLIGHT_CLASS_DEVICE if ACPI
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/Kconfig b/drivers/gpu/drm/hisilicon/hibmc/Kconfig
> index 073adfe438dd..90b9e6cce49c 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/Kconfig
> +++ b/drivers/gpu/drm/hisilicon/hibmc/Kconfig
> @@ -6,6 +6,8 @@ config DRM_HISI_HIBMC
> select DRM_VRAM_HELPER
> select DRM_TTM
> select DRM_TTM_HELPER
> + select I2C
> + select I2C_ALGOBIT
> help
> Choose this option if you have a Hisilicon Hibmc soc chipset.
> If M is selected the module will be called hibmc-drm.
> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> index 3efce05d7b57..c6e3792622f2 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -18,6 +18,8 @@ config DRM_I915
> select DRM_PANEL
> select DRM_MIPI_DSI
> select RELAY
> + select I2C
> + select I2C_ALGOBIT
> select IRQ_WORK
> # i915 depends on ACPI_VIDEO when ACPI is enabled
> # but for select to work, need to select ACPI_VIDEO's dependencies, ick
> diff --git a/drivers/gpu/drm/mgag200/Kconfig b/drivers/gpu/drm/mgag200/Kconfig
> index eec59658a938..b28c5e4828f4 100644
> --- a/drivers/gpu/drm/mgag200/Kconfig
> +++ b/drivers/gpu/drm/mgag200/Kconfig
> @@ -4,6 +4,8 @@ config DRM_MGAG200
> depends on DRM && PCI && MMU
> select DRM_GEM_SHMEM_HELPER
> select DRM_KMS_HELPER
> + select I2C
> + select I2C_ALGOBIT
> help
> This is a KMS driver for Matrox G200 chips. It supports the original
> MGA G200 desktop chips and the server variants. It requires 0.3.0
> diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
> index 03d12caf9e26..a0bb3987bf63 100644
> --- a/drivers/gpu/drm/nouveau/Kconfig
> +++ b/drivers/gpu/drm/nouveau/Kconfig
> @@ -10,6 +10,8 @@ config DRM_NOUVEAU
> select DRM_KMS_HELPER
> select DRM_TTM
> select DRM_TTM_HELPER
> + select I2C
> + select I2C_ALGOBIT
> select BACKLIGHT_CLASS_DEVICE if DRM_NOUVEAU_BACKLIGHT
> select X86_PLATFORM_DEVICES if ACPI && X86
> select ACPI_WMI if ACPI && X86
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20221128/cda884e2/attachment.sig>
More information about the dri-devel
mailing list