[PATCH v3] drm/vmwgfx: Fix race issue calling pin_user_pages

Zack Rusin zackr at vmware.com
Tue Nov 29 14:47:56 UTC 2022


On Mon, 2022-11-28 at 22:56 +0800, Dawei Li wrote:
> On Wed, Nov 09, 2022 at 11:37:34PM +0800, Dawei Li wrote:
> > pin_user_pages() is unsafe without protection of mmap_lock,
> > fix it by calling pin_user_pages_fast().
> > 
> > Fixes: 7a7a933edd6c ("drm/vmwgfx: Introduce VMware mks-guest-stats")
> > Signed-off-by: Dawei Li <set_pte_at at outlook.com>
> > ---
> > v1:
> > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2FTYCP286MB23235C9A9FCF85C045F95EA7CA4F9%40TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM%2F&data=05%7C01%7Czackr%40vmware.com%7C7960fb10f8b443e33e4508dad150af04%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C1%7C638052441759507541%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=N9jdnLfT0kp9KifspFyH2GfmAwnH7NJdQE6255UY5JE%3D&reserved=0
> > 
> > v1->v2:
> > Rebased to latest vmwgfx/drm-misc-fixes.
> > 
> > v2->v3
> > Replace pin_user_pages() with pin_user_pages_fast().
> 
> Gentle ping

Thank you. I've just pushed it to drm-misc-fixes:
https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-fixes&id=ed14d225cc7c842f6d4d5a3009f71a44f5852d09
so it's going to find its way upstream soon.

z



More information about the dri-devel mailing list