[PATCH 0/5] drm: Fix math issues in MSM DSC implementation
Vinod Koul
vkoul at kernel.org
Tue Oct 4 04:42:58 UTC 2022
On 01-10-22, 21:08, Marijn Suijten wrote:
> Various removals of complex yet unnecessary math, fixing all uses of
> drm_dsc_config::bits_per_pixel to deal with the fact that this field
> includes four fractional bits, and finally an approach for dealing with
> dsi_host setting negative values in range_bpg_offset, resulting in
> overflow inside drm_dsc_pps_payload_pack().
>
> Note that updating the static bpg_offset array to limit the size of
> these negative values to 6 bits changes what would be written to the DPU
> hardware at register(s) DSC_RANGE_BPG_OFFSET, hence the choice has been
> made to cover up for this while packing the value into a smaller field
> instead.
Thanks for fixing these. I dont have my pixel3 availble but changes lgtm
Reviewed-by: Vinod Koul <vkoul at kernel.org>
> Altogether this series is responsible for solving _all_ Display Stream
> Compression issues and artifacts on the Sony Tama (sdm845) Akatsuki
> smartphone (2880x1440p).
Does it need two dsi lanes?
--
~Vinod
More information about the dri-devel
mailing list