[PATCH v4 2/2] drm/atomic-helper: Replace drm_atomic_helper_check_crtc_state()

Javier Martinez Canillas javierm at redhat.com
Fri Oct 7 07:41:33 UTC 2022


On 10/7/22 09:29, Ville Syrjälä wrote:

[...]

>> 	drm_for_each_plane_mask(plane, dev, crtc_state->plane_mask)
>> 		if (plane->type == DRM_PLANE_TYPE_PRIMARY)
>> 			return 0;
> 
> That is exactly what it says not to do.
> 

Ah, good to know. I re-read the kernel coding style and see now
that it only applies to single simple statements.

Better then, since not using braces even for single statements
is something that's error prone IMO, as mentioned before.

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



More information about the dri-devel mailing list