[PATCH 3/8] drm/ast: Do not call drm_atomic_add_affected_planes()
Javier Martinez Canillas
javierm at redhat.com
Mon Oct 10 17:06:24 UTC 2022
Hello Thomas,
On 10/10/22 12:36, Thomas Zimmermann wrote:
> There's no need to add planes to the atomic state. Remove the call
> to drm_atomic_add_affected_planes() from ast.
>
> On full modesets, the DRM helpers already add a CRTC's planes to the
> atomic state; see drm_atomic_helper_check_modeset(). There's no reason
> to call drm_atomic_add_affected_planes() unconditionally in the CRTC's
> atomic_check() in ast. It's also too late, as the atomic_check() of
> the added planes will not be called before the commit.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> ---
The change makes sense to me.
Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
More information about the dri-devel
mailing list