[PATCH 1/2] drm: remove DRM_MINOR_CONTROL
Christian König
ckoenig.leichtzumerken at gmail.com
Tue Oct 11 11:55:01 UTC 2022
Am 11.10.22 um 13:39 schrieb Simon Ser:
> On Tuesday, October 11th, 2022 at 13:04, Christian König <ckoenig.leichtzumerken at gmail.com> wrote:
>
>> --- a/include/drm/drm_file.h
>> +++ b/include/drm/drm_file.h
>> @@ -54,7 +54,6 @@ struct file;
>> */
>> enum drm_minor_type {
>> DRM_MINOR_PRIMARY,
>> - DRM_MINOR_CONTROL,
>> DRM_MINOR_RENDER,
>> };
> This makes me uncomfortable: this enum no longer matches DRM_NODE_* in
> libdrm.
Ah! There it was! I was remembering in the back of my head that we had
somehow used this in libdrm as well, but couldn't really get where exactly.
But I don't really see a problem here. The control nodes are identified
by name and we don't expose them for quite some time now without any
negative impact.
Even the minor number distribution stays the same. So what bad can come
from this?
Thanks,
Christian.
More information about the dri-devel
mailing list