[PATCH] drm/omapdrm: Remove unused struct csc_coef_rgb2yuv

Cai Huoqing cai.huoqing at linux.dev
Thu Oct 13 06:39:32 UTC 2022


On 27 9月 22 13:38:47, Yuan Can wrote:
> After commit 64ff18911878("drm/omap: Enable COLOR_ENCODING and COLOR_RANGE
Hi yuan,

This is not a valid Fixes: tag.

Add to your ~/.gitconfig and add:

[pretty]
        fixes = Fixes: %h (\"%s\")

You can then do

git log --pretty=fixes 64ff18911878

and get:

Fixes: 64ff18911878 ("drm/omap: Enable COLOR_ENCODING and COLOR_RANGE properties for planes")

Which is the correct format. Don't wrap it, if it is long.

Thanks,
Cai

> properties for planes"), no one use struct csc_coef_rgb2yuv, so remove it.
> 
> Signed-off-by: Yuan Can <yuancan at huawei.com>
> ---
>  drivers/gpu/drm/omapdrm/dss/dispc.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c
> index 0ee344ebcd1c..aacad5045e95 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dispc.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c
> @@ -855,11 +855,6 @@ struct csc_coef_yuv2rgb {
>  	bool full_range;
>  };
>  
> -struct csc_coef_rgb2yuv {
> -	int yr, yg, yb, cbr, cbg, cbb, crr, crg, crb;
> -	bool full_range;
> -};
> -
>  static void dispc_ovl_write_color_conv_coef(struct dispc_device *dispc,
>  					    enum omap_plane_id plane,
>  					    const struct csc_coef_yuv2rgb *ct)
> -- 
> 2.17.1
> 


More information about the dri-devel mailing list