[PATCH v2] drm/panel/panel-sitronix-st7701: Fix RTNI calculation

Marek Vasut marex at denx.de
Tue Oct 18 10:00:58 UTC 2022


On 10/18/22 11:13, Linus Walleij wrote:
> On Tue, Oct 18, 2022 at 11:03 AM Marek Vasut <marex at denx.de> wrote:
>> On 10/18/22 10:53, Linus Walleij wrote:
>>> On Thu, Oct 13, 2022 at 12:12 AM Marek Vasut <marex at denx.de> wrote:
>>>
>>>> The RTNI field is multiplied by 16 and incremented by 512 before being
>>>> used as the minimum number of pixel clock per horizontal line, hence
>>>> it is necessary to subtract those 512 bytes from htotal and then divide
>>>> the result by 16 before writing the value into the RTNI field. Fix the
>>>> calculation.
>>>>
>>>> Fixes: de2b4917843c ("drm/panel/panel-sitronix-st7701: Infer horizontal pixel count from TFT mode")
>>>> Signed-off-by: Marek Vasut <marex at denx.de>
>>>> ---
>>>> Cc: Guido Günther <agx at sigxcpu.org>
>>>> Cc: Jagan Teki <jagan at amarulasolutions.com>
>>>> Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>>>> Cc: Linus Walleij <linus.walleij at linaro.org>
>>>> Cc: Sam Ravnborg <sam at ravnborg.org>
>>>> Cc: Thierry Reding <thierry.reding at gmail.com>
>>>> ---
>>>> V2: Clamp the htotal to range 512...1008, so RTNI always fits the bitfield
>>>
>>> I tried to apply this to drm-misc-fixes but the branch has not yet
>>> been moved forward to v6.1-rc1.
>>
>> Can I maybe get RB until then ?
> 
> Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Thank you

> I've been told to go and poke the DRM git people at IRC to rebase
> the fixes branch.

That would be #dri-devel on OFTC I think ?


More information about the dri-devel mailing list