[PATCH v5 01/10] gna: add PCI driver module

[Andy Shevchenko]

On Thu, Oct 20, 2022 at 8:57 PM Maciej Kwapulinski
<maciej.kwapulinski at linux.intel.com> wrote:
>
> Add a new PCI driver for Intel(R) Gaussian & Neural Accelerator
> with basic support like module loading and unloading. The full
> function of the driver will be added by further changes.

...

> +GNA_GEM_NEW acquires new 4KB page aligned memory region ready for DMA operations.

a new

...

> +GNA Library can allocate any number of memory regions for GNA usage. Its number and total
> +capacity are limited by the OSs’ resources. Due to GNA MMU restrictions, even when using

OSes' ?

> +multiple memory regions, the sum of all the memory regions used within a single inference
> +request must be no larger than 256MB.

...

> +++ b/drivers/gpu/drm/Kconfig
> @@ -403,6 +403,8 @@ source "drivers/gpu/drm/solomon/Kconfig"
>
>  source "drivers/gpu/drm/sprd/Kconfig"
>
> +source "drivers/gpu/drm/gna/Kconfig"

It looks to me that you broke the order here.

...

> @@ -147,3 +147,4 @@ obj-y                       += gud/
>  obj-$(CONFIG_DRM_HYPERV) += hyperv/
>  obj-y                  += solomon/
>  obj-$(CONFIG_DRM_SPRD) += sprd/
> +obj-$(CONFIG_DRM_GNA) += gna/

Ditto.

...

> +config DRM_GNA
> +       tristate "Intel(R) Gaussian & Neural Accelerator (Intel(R) GNA)"
> +       depends on X86 && PCI

No compile test for the rest of possible options?

-- 
With Best Regards,
Andy Shevchenko