[PATCH v5 02/10] gna: add GNA DRM device

[Andy Shevchenko]

On Thu, Oct 20, 2022 at 8:57 PM Maciej Kwapulinski
<maciej.kwapulinski at linux.intel.com> wrote:

Missed commit message.

> Signed-off-by: Maciej Kwapulinski <maciej.kwapulinski at linux.intel.com>
> Tested-by: Mikolaj Grzybowski <mikolajx.grzybowski at intel.com>

...

> +       if (!(sizeof(dma_addr_t) > 4) ||

Do you really need this?

> +               dma_set_mask(parent, DMA_BIT_MASK(64))) {

> +               err = dma_set_mask(parent, DMA_BIT_MASK(32));
> +               if (err)
> +                       return err;

IIRC if the 64-bit dma_set_mask() fails, there is no need to check
32-bit, i.e. it will fail.

> +       }

...

> +#define DRIVER_DATE            "20211201"

Really?

...

> +#include <linux/mm_types.h>

Are you sure?

> +struct gna_dev_info {
> +       u32 hwid;
> +       u32 num_pagetables;
> +       u32 num_page_entries;
> +       u32 max_layer_count;
> +       u64 max_hw_mem;
> +};

-- 
With Best Regards,
Andy Shevchenko