[PATCH v5 06/10] gna: add GNA_GEM_NEW and GNA_GEM_FREE ioctls

Andy Shevchenko andy.shevchenko at gmail.com
Thu Oct 20 19:06:28 UTC 2022


On Thu, Oct 20, 2022 at 8:57 PM Maciej Kwapulinski
<maciej.kwapulinski at linux.intel.com> wrote:
>
> drm_gem_shmem_object is base for memory objects provided by the patch

Here and in some other commit messages don't forget English
punctuation, like trailing period.

...

> +struct gna_gem_object {
> +       struct drm_gem_shmem_object base;
> +
> +       uint32_t handle;

Not u32 or __u32? Is it a subsystem requirement to have uint32_t? Or
your driver, then why are you not using similar types elsewhere?

> +};

-- 
With Best Regards,
Andy Shevchenko


More information about the dri-devel mailing list