[PATCH v3 17/17] drm/vmwgfx: Fix a sparse warning in kernel docs

Maaz Mombasawala (VMware maazm at fastmail.com
Fri Oct 21 20:00:26 UTC 2022


On 10/20/22 20:44, Zack Rusin wrote:
> From: Zack Rusin <zackr at vmware.com>
> 
> Fixes a warning about extra docs about a function argument that has been
> removed a while back:
> drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3888: warning: Excess function
> parameter 'sync_file' description in 'vmw_execbuf_copy_fence_user'
> 
> Fixes: a0f90c881570 ("drm/vmwgfx: Fix stale file descriptors on failed usercopy")
> Signed-off-by: Zack Rusin <zackr at vmware.com>
> ---
>  drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index c943ab801ca7..f16fc489d725 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -3869,7 +3869,6 @@ int vmw_execbuf_fence_commands(struct drm_file *file_priv,
>   * @fence: Pointer to the fenc object.
>   * @fence_handle: User-space fence handle.
>   * @out_fence_fd: exported file descriptor for the fence.  -1 if not used
> - * @sync_file:  Only used to clean up in case of an error in this function.
>   *
>   * This function copies fence information to user-space. If copying fails, the
>   * user-space struct drm_vmw_fence_rep::error member is hopefully left

-- 

Looks good.

Reviewed-by: Maaz Mombasawala <mombasawalam at vmware.com>

Maaz Mombasawala (VMware) <maazm at fastmail.com>



More information about the dri-devel mailing list