[PATCH] drm/tests: Add back seed value information
Maíra Canal
mairacanal at riseup.net
Wed Oct 26 21:34:41 UTC 2022
Hi Arthur,
On 10/26/22 18:14, Arthur Grillo wrote:
> As reported by Michał the drm_mm and drm_buddy unit tests lost the
> printk with seed value after they being refactored into kunit. This
Some grammar nits:
- s/being/were
- s/kunit/KUnit
> patch adds back this important information to assure reproducibility
> converting them to use the kunit api.
>
> Signed-off-by: Arthur Grillo <arthurgrillo at riseup.net>
> Reported-by: Michał Winiarski <michal.winiarski at intel.com>
I believe that Michał's should come before your tag, as the SoB chain
should reflect the real route a patch took as it was propagated to the
maintainers [1].
> ---
> drivers/gpu/drm/tests/drm_buddy_test.c | 3 +++
> drivers/gpu/drm/tests/drm_mm_test.c | 4 +++-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c
> index 62f69589a72d..83c8863bc643 100644
> --- a/drivers/gpu/drm/tests/drm_buddy_test.c
> +++ b/drivers/gpu/drm/tests/drm_buddy_test.c
> @@ -731,6 +731,9 @@ static int drm_buddy_init_test(struct kunit *test)
> while (!random_seed)
> random_seed = get_random_u32();
>
> + kunit_info("Testing DRM buddy manager (struct drm_buddy), with random_seed=0x%x\n",
> + random_seed);
I'm getting some compiling errors here:
ERROR:root:../drivers/gpu/drm/tests/drm_buddy_test.c:735:3: error:
expected ')'
random_seed);
^
../drivers/gpu/drm/tests/drm_buddy_test.c:734:2: note: to match this '('
kunit_info("Testing DRM buddy manager (struct drm_buddy), with
random_seed=0x%x\n",
^
You can reproduce it by running:
$ ./tools/testing/kunit/kunit.py --kunitconfig=drivers/gpu/drm/tests
Moreover, could you address the checkpatch issues? There are some
misaligned parenthesis and the line are too big.
> +
> return 0;
> }
>
> diff --git a/drivers/gpu/drm/tests/drm_mm_test.c b/drivers/gpu/drm/tests/drm_mm_test.c
> index c4b66eeae203..492347069d58 100644
> --- a/drivers/gpu/drm/tests/drm_mm_test.c
> +++ b/drivers/gpu/drm/tests/drm_mm_test.c
> @@ -2214,6 +2214,9 @@ static int drm_mm_init_test(struct kunit *test)
> while (!random_seed)
> random_seed = get_random_u32();
>
> + kunit_info("Testing DRM range manager (struct drm_mm), with random_seed=0x%x max_iterations=%u max_prime=%u\n",
> + random_seed, max_iterations, max_prime);
> +
Same here.
> return 0;
> }
>
> @@ -2251,6 +2254,5 @@ static struct kunit_suite drm_mm_test_suite = {
> };
>
> kunit_test_suite(drm_mm_test_suite);
> -
There is no need to change this line.
Thanks for your patch!
[1]
https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
Best Regards,
- Maíra Canal
> MODULE_AUTHOR("Intel Corporation");
> MODULE_LICENSE("GPL");
More information about the dri-devel
mailing list