[PATCH v2 3/5] drm/gma500: Use backlight_get_brightness() to get the brightness

[Sam Ravnborg]

Hi Hans,

On Sat, Sep 17, 2022 at 11:00:55PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 9/17/22 22:46, Sam Ravnborg wrote:
> > On Sat, Sep 17, 2022 at 04:03:50PM +0200, Hans de Goede wrote:
> >> Use backlight_get_brightness() instead of directly referencing
> >> bd->props.brightness. This will take backlight_is_blank() into account,
> >> properly setting brightness to 0 when screen-blanking has been requested
> >> through the backlight sysfs interface.
> >>
> >> Suggested-by: Sam Ravnborg <sam at ravnborg.org>
> >> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> > Acked-by: Sam Ravnborg <sam at ravnborg.org>
> 
> Thank you.
> 
> I have just send out a v3 with your ack added and fixing the
> 2 unused variables when CONFIG_BACKLIGHT is not set spotted
> by the lkp test robot.
> 
> I was sort of hoping that you could review / ack the entire
> series ?
OK, I may take a closer look tomorrow then (as time permits - needs to
prepare for a business trip too).
I have not looked at gma500 code that much so I hope Patrick
takes a look too.

	Sam