[v2] drm/msm: add null checks for drm device to avoid crash during probe defer

Vinod Polimera vpolimer at qti.qualcomm.com
Tue Sep 27 09:41:43 UTC 2022



> -----Original Message-----
> From: Javier Martinez Canillas <javierm at redhat.com>
> Sent: Tuesday, September 27, 2022 2:33 PM
> To: Vinod Polimera <vpolimer at qti.qualcomm.com>;
> dmitry.baryshkov at linaro.org; Vinod Polimera (QUIC)
> <quic_vpolimer at quicinc.com>; dri-devel at lists.freedesktop.org; linux-arm-
> msm at vger.kernel.org; freedreno at lists.freedesktop.org;
> devicetree at vger.kernel.org
> Cc: dianders at chromium.org; vpolimer at quicinc.com; Abhinav Kumar
> <abhinavk at quicinc.com>; linux-kernel at vger.kernel.org;
> swboyd at chromium.org; kalyant at quicinc.com
> Subject: Re: [v2] drm/msm: add null checks for drm device to avoid crash
> during probe defer
> 
> WARNING: This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
> 
> Hello Vinod and Dmitry,
> 
> On 9/27/22 09:31, Vinod Polimera wrote:
> >> -----Original Message-----
> >> From: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> >> Sent: Friday, August 26, 2022 2:11 PM
> >> To: Vinod Polimera (QUIC) <quic_vpolimer at quicinc.com>; dri-
> >> devel at lists.freedesktop.org; linux-arm-msm at vger.kernel.org;
> >> freedreno at lists.freedesktop.org; devicetree at vger.kernel.org
> >> Cc: linux-kernel at vger.kernel.org; robdclark at gmail.com;
> >> dianders at chromium.org; vpolimer at quicinc.com;
> swboyd at chromium.org;
> >> kalyant at quicinc.com
> >> Subject: Re: [v2] drm/msm: add null checks for drm device to avoid crash
> >> during probe defer
> >>
> 
> [...]
> 
> >> Vinod, do we still want to pursue this fix? If so, could you please
> >> update it according to the comment.
> >>
> 
> I don't think this patch is needed anymore, since AFAICT the issue has
> been fixed by commit 0a58d2ae572a ("drm/msm: Make .remove and
> .shutdown
> HW shutdown consistent") which is already in the drm/drm-next branch.
Yes , Issue will be fixed with the  commit 0a58d2ae572a ("drm/msm: Make .remove and .shutdown) . Hence  we can  drop this patch.
> 
> --
> Best regards,
> 
> Javier Martinez Canillas
> Core Platforms
> Red Hat

- Vinod P.



More information about the dri-devel mailing list