[PATCH v4 4/4] drm: lcdif: Add support for YUV planes
Liu Ying
victor.liu at nxp.com
Fri Sep 30 10:35:28 UTC 2022
On Fri, 2022-09-30 at 11:39 +0300, Laurent Pinchart wrote:
> From: Kieran Bingham <kieran.bingham at ideasonboard.com>
>
> The LCDIF includes a color space converter that supports YUV input.
> Use
> it to support YUV planes, either through the converter if the output
> format is RGB, or in conversion bypass mode otherwise.
>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Reviewed-by: Marek Vasut <marex at denx.de>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
> Changes since v3:
>
> - Add YCbCr to RGB conversion formula in a comment
> - Fix small typo in comment
>
> Changes since v2:
>
> - Fix YUV to RGB coefficients
> - List floating point coefficient values in comment
> - Express CSC coefficients with three hex digits
> - Move | to the end of the line
> - Add comment header before RGB formats
>
> Changes since v1:
>
> - Support all YCbCr encodings and quantization ranges
> - Drop incorrect comment
> ---
> drivers/gpu/drm/mxsfb/lcdif_kms.c | 267 ++++++++++++++++++++++++---
> --
> drivers/gpu/drm/mxsfb/lcdif_regs.h | 5 +-
> 2 files changed, 231 insertions(+), 41 deletions(-)
Although modetest shows wrong display image for YUV framebuffers due to
the pre-existing bug that Laurent claims, I choose to trust Laurent,
so:
Reviewed-by: Liu Ying <victor.liu at nxp.com>
Thanks Laurent and Kieran for the work.
More information about the dri-devel
mailing list