[PATCH] video/aperture: fix typos
Javier Martinez Canillas
javierm at redhat.com
Tue Apr 4 10:55:56 UTC 2023
Thomas Zimmermann <tzimmermann at suse.de> writes:
Hello Thomas,
Sorry, I just applied this patch and didn't see your email before...
> Hi
>
> Am 04.04.23 um 06:01 schrieb Sui Jingfeng:
>> EFI FB, VESA FB or VGA FB etc are belong to firmware based framebuffer
>> driver.
>
> No whitespaces at the beginning of the lines.
>
I fixed that before applying, also removed the "are" in the sentence
above, since it sounded off and repharsed subject line as "Fix typos
in comments".
[...]
>> /*
>> * Remove the device from the device hierarchy. This is the right thing
>> - * to do for firmware-based DRM drivers, such as EFI, VESA or VGA. After
>> + * to do for firmware-based fb drivers, such as EFI, VESA or VGA. After
>
> That sentences is not well phrased. Maybe say 'This is required for
> firmware-provided graphics, such as EFI, VESA or VGA.'
>
Graphic drivers or display drivers would indeed be more accurate here. But
I think that "fb drivers" is still well pharsed since the are other places
where either fbdev or DRM drivers for firmware-provided framebuffers are
named like that.
For example, in the sysfb platform code and Kconfig symbol help text.
> Best regards
> Thomas
>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
More information about the dri-devel
mailing list