[PATCH v3 63/65] ASoC: tlv320aic32x4: pll: Switch to determine_rate
Mark Brown
broonie at kernel.org
Wed Apr 5 15:09:49 UTC 2023
On Tue, Apr 04, 2023 at 12:11:53PM +0200, Maxime Ripard wrote:
> The driver does implement round_rate() though, which means that we can
> change the rate of the clock, but we will never get to change the
> parent.
> However, It's hard to tell whether it's been done on purpose or not.
> Since we'll start mandating a determine_rate() implementation, let's
> convert the round_rate() implementation to a determine_rate(), which
> will also make the current behavior explicit. And if it was an
> oversight, the clock behaviour can be adjusted later on.
Similar comments to the other patch, I'm pretty sure this is just
surprising design on the part of the clock API and we should just allow
reparenting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20230405/a8b501b9/attachment.sig>
More information about the dri-devel
mailing list