[PATCH] firmware/sysfb: Fix wrong stride when bits-per-pixel is calculated

Pierre Asselin pa at panix.com
Thu Apr 13 17:17:00 UTC 2023


> diff --git a/drivers/firmware/sysfb_simplefb.c
> b/drivers/firmware/sysfb_simplefb.c
> index 82c64cb9f531..0ab8c542b1f5 100644
> --- a/drivers/firmware/sysfb_simplefb.c
> +++ b/drivers/firmware/sysfb_simplefb.c
> @@ -55,14 +55,10 @@ __init bool sysfb_parse_mode(const struct screen_info
> *si,
>  	 * ignore simplefb formats with alpha bits, as EFI and VESA
>  	 * don't specify alpha channels.
>  	 */
> -	if (si->lfb_depth > 8) {
> -		bits_per_pixel = max(max3(si->red_size + si->red_pos,
> -					  si->green_size + si->green_pos,
> -					  si->blue_size + si->blue_pos),
> -				     si->rsvd_size + si->rsvd_pos);
> -	} else {
> +	if (si->lfb_depth > 8)
> +		bits_per_pixel = si->lfb_linelength * 8 / si->lfb_width;
> +	else
>  		bits_per_pixel = si->lfb_depth;
> -	}
>
>  	for (i = 0; i < ARRAY_SIZE(formats); ++i) {
>  		const struct simplefb_format *f = &formats[i];
>
> base-commit: e62252bc55b6d4eddc6c2bdbf95a448180d6a08d
> --
> 2.40.0

Patch is good on both boxes.




More information about the dri-devel mailing list