[PATCH v2 0/7] drm/vkms: introduce plane rotation property
Maíra Canal
mcanal at igalia.com
Fri Apr 14 13:51:44 UTC 2023
This patchset implements all possible rotation value in vkms. All operations
were implemented by software by changing the way the pixels are read. The way
the blending is performed can be depicted as:
- rotate-0:
(x) ---->
----------------------
(y) | |
| | |
| | |
ˇ | |
----------------------
- rotate-90:
<---- (y)
----------------------
(x) | |
| | |
| | |
ˇ | |
----------------------
- rotate-180:
<---- (x)
----------------------
(y) | |
^ | |
| | |
| | |
----------------------
- rotate-270:
(y) ---->
----------------------
(x) | |
^ | |
| | |
| | |
----------------------
- reflect-x:
<---- (x)
----------------------
(y) | |
| | |
| | |
ˇ | |
----------------------
- reflect-y:
(x) ---->
----------------------
(y) | |
^ | |
| | |
| | |
----------------------
The patchset was tested with IGT's kms_rotation_crc tests and also with some
additional tests [1] for the reflection operations.
In order to avoid code duplication, I introduced a patch that isolates the
pixel format convertion and wraps it in a single loop.
v1 -> v2:
* Add patch to isolate pixel format convertion (Arthur Grillo).
[1] https://patchwork.freedesktop.org/series/116025/
Best Regards,
- Maíra Canal
Maíra Canal (7):
drm/vkms: isolate pixel conversion functionality
drm/vkms: add rotate-0 and rotate-180 properties
drm/vkms: add rotate-90 property
drm/vkms: add rotate-270 property
drm/vkms: add reflect-x property
drm/vkms: add reflect-y property
drm/vkms: drop "Rotation" TODO
Documentation/gpu/vkms.rst | 2 +-
drivers/gpu/drm/vkms/vkms_composer.c | 79 +++++++++++---
drivers/gpu/drm/vkms/vkms_drv.h | 5 +-
drivers/gpu/drm/vkms/vkms_formats.c | 153 ++++++++++++++-------------
drivers/gpu/drm/vkms/vkms_formats.h | 2 +-
drivers/gpu/drm/vkms/vkms_plane.c | 12 ++-
6 files changed, 163 insertions(+), 90 deletions(-)
--
2.39.2
More information about the dri-devel
mailing list