[PATCH] gpu: gma500: psb_drv: add missing unwind goto

Hongqi Chen U202112190 at hust.edu.cn
Mon Apr 17 06:01:05 UTC 2023


Smatch reports that missing unwind goto in psb_driver_load().
drivers/gpu/drm/gma500/psb_drv.c:350 psb_driver_load() warn: missing
unwind goto?

psb_driver_unload() and psb_driver_load() exist in correspondence, 
and psb_driver_unload() should be executed when the psb_do_init() 
fails to initialize.

Fixes: 5c49fd3aa0ab ("gma500: Add the core DRM files and headers")
Signed-off-by: Hongqi Chen <U202112190 at hust.edu.cn>
Reviewed-by: Dongliang Mu <dzm91 at hust.edu.cn>
---
 drivers/gpu/drm/gma500/psb_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
index cd9c73f5a64a..b5a276342129 100644
--- a/drivers/gpu/drm/gma500/psb_drv.c
+++ b/drivers/gpu/drm/gma500/psb_drv.c
@@ -347,7 +347,7 @@ static int psb_driver_load(struct drm_device *dev, unsigned long flags)
 
 	ret = psb_do_init(dev);
 	if (ret)
-		return ret;
+		goto out_err;
 
 	/* Add stolen memory to SGX MMU */
 	ret = psb_mmu_insert_pfn_sequence(psb_mmu_get_default_pd(dev_priv->mmu),
-- 
2.25.1



More information about the dri-devel mailing list