[PATCH v2 06/17] drm/msm/dpu: Remove extraneous register define indentation
Konrad Dybcio
konrad.dybcio at linaro.org
Tue Apr 18 12:18:29 UTC 2023
On 17.04.2023 22:21, Marijn Suijten wrote:
> A bunch of registers are indented with two extra spaces, looking as if
> these are values corresponding to the previous register which is not the
> case, rather these are simply also register offsets and should only have
> a single space separating them and the #define keyword.
>
> Signed-off-by: Marijn Suijten <marijn.suijten at somainline.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio at linaro.org>
Konrad
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 41 +++++++++++++++--------------
> 1 file changed, 21 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c
> index b9dddf576c02..1d22d7dc99b8 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c
> @@ -38,26 +38,27 @@
> #define INTF_ACTIVE_DATA_HCTL 0x068
> #define INTF_FRAME_LINE_COUNT_EN 0x0A8
> #define INTF_FRAME_COUNT 0x0AC
> -#define INTF_LINE_COUNT 0x0B0
> -
> -#define INTF_DEFLICKER_CONFIG 0x0F0
> -#define INTF_DEFLICKER_STRNG_COEFF 0x0F4
> -#define INTF_DEFLICKER_WEAK_COEFF 0x0F8
> -
> -#define INTF_DSI_CMD_MODE_TRIGGER_EN 0x084
> -#define INTF_PANEL_FORMAT 0x090
> -#define INTF_TPG_ENABLE 0x100
> -#define INTF_TPG_MAIN_CONTROL 0x104
> -#define INTF_TPG_VIDEO_CONFIG 0x108
> -#define INTF_TPG_COMPONENT_LIMITS 0x10C
> -#define INTF_TPG_RECTANGLE 0x110
> -#define INTF_TPG_INITIAL_VALUE 0x114
> -#define INTF_TPG_BLK_WHITE_PATTERN_FRAMES 0x118
> -#define INTF_TPG_RGB_MAPPING 0x11C
> -#define INTF_PROG_FETCH_START 0x170
> -#define INTF_PROG_ROT_START 0x174
> -#define INTF_MUX 0x25C
> -#define INTF_STATUS 0x26C
> +#define INTF_LINE_COUNT 0x0B0
> +
> +#define INTF_DEFLICKER_CONFIG 0x0F0
> +#define INTF_DEFLICKER_STRNG_COEFF 0x0F4
> +#define INTF_DEFLICKER_WEAK_COEFF 0x0F8
> +
> +#define INTF_DSI_CMD_MODE_TRIGGER_EN 0x084
> +#define INTF_PANEL_FORMAT 0x090
> +#define INTF_TPG_ENABLE 0x100
> +#define INTF_TPG_MAIN_CONTROL 0x104
> +#define INTF_TPG_VIDEO_CONFIG 0x108
> +#define INTF_TPG_COMPONENT_LIMITS 0x10C
> +#define INTF_TPG_RECTANGLE 0x110
> +#define INTF_TPG_INITIAL_VALUE 0x114
> +#define INTF_TPG_BLK_WHITE_PATTERN_FRAMES 0x118
> +#define INTF_TPG_RGB_MAPPING 0x11C
> +#define INTF_PROG_FETCH_START 0x170
> +#define INTF_PROG_ROT_START 0x174
> +
> +#define INTF_MUX 0x25C
> +#define INTF_STATUS 0x26C
>
> #define INTF_CFG_ACTIVE_H_EN BIT(29)
> #define INTF_CFG_ACTIVE_V_EN BIT(30)
>
More information about the dri-devel
mailing list