[PATCH 2/3] drm/msm/dpu: Assign missing writeback log_mask

Abhinav Kumar quic_abhinavk at quicinc.com
Wed Apr 19 16:05:47 UTC 2023



On 4/19/2023 2:28 AM, Marijn Suijten wrote:
> On 2023-04-18 09:06:34, Abhinav Kumar wrote:
>>
>> On 4/17/2023 4:14 PM, Marijn Suijten wrote:
>>> The WB debug log mask ended up never being assigned, leading to writes
>>> to this block to never be logged even if the mask is enabled in
>>> dpu_hw_util_log_mask via sysfs.
>>
>> This should be debugfs not sysfs.
> 
> Good catch!  I've queued this up for v2 if it comes to it, otherwise it
> can perhaps be fixed up while applying for msm-fixes?
> 

Yes, I can fix it up while applying to -fixes.

>>> Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback blocks")
>>> Signed-off-by: Marijn Suijten <marijn.suijten at somainline.org>
>>> ---
>>
>> With that fixed,
>>
>> Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>
> 
> Thanks!
> 
> - Marijn


More information about the dri-devel mailing list