[PATCH 2/2] drm/dsc: fix DP_DSC_MAX_BPP_DELTA_* macro values

Nautiyal, Ankit K ankit.k.nautiyal at intel.com
Thu Apr 20 12:45:55 UTC 2023


LGTM.

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal at intel.com>

On 4/6/2023 7:16 PM, Jani Nikula wrote:
> The macro values just don't match the specs. Fix them.
>
> Fixes: 1482ec00be4a ("drm: Add missing DP DSC extended capability definitions.")
> Cc: Vinod Govindapillai <vinod.govindapillai at intel.com>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> ---
>   include/drm/display/drm_dp.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h
> index 89d5a700b04d..f8813c1e059b 100644
> --- a/include/drm/display/drm_dp.h
> +++ b/include/drm/display/drm_dp.h
> @@ -286,8 +286,8 @@
>   
>   #define DP_DSC_MAX_BITS_PER_PIXEL_HI        0x068   /* eDP 1.4 */
>   # define DP_DSC_MAX_BITS_PER_PIXEL_HI_MASK  (0x3 << 0)
> -# define DP_DSC_MAX_BPP_DELTA_VERSION_MASK  0x06
> -# define DP_DSC_MAX_BPP_DELTA_AVAILABILITY  0x08
> +# define DP_DSC_MAX_BPP_DELTA_VERSION_MASK  (0x3 << 5)	/* eDP 1.5 & DP 2.0 */
> +# define DP_DSC_MAX_BPP_DELTA_AVAILABILITY  (1 << 7)	/* eDP 1.5 & DP 2.0 */
>   
>   #define DP_DSC_DEC_COLOR_FORMAT_CAP         0x069
>   # define DP_DSC_RGB                         (1 << 0)


More information about the dri-devel mailing list