[PATCH -next v2] drm/i2c: tda998x: remove redundant CONFIG_OF and of_match_ptr

Andy Shevchenko andriy.shevchenko at linux.intel.com
Tue Aug 1 18:00:04 UTC 2023


On Tue, Aug 01, 2023 at 11:32:20AM +0800, Zhu Wang wrote:
> The driver depends on CONFIG_OF, so it is not necessary to use CONFIG_OF
> and of_match_ptr here, we remove them all.
> 
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it.

Instead, you may convert this driver to use device property APIs and make it
OF-free (okay, almost, with one API that still would be called for OF, but not
for the rest).

-- 
With Best Regards,
Andy Shevchenko




More information about the dri-devel mailing list