[PATCH -next v3] drm/i2c: tda998x: remove redundant CONFIG_OF and of_match_ptr()

Andy Shevchenko andriy.shevchenko at linux.intel.com
Thu Aug 3 13:09:18 UTC 2023


On Wed, Aug 02, 2023 at 03:42:04PM +0800, Zhu Wang wrote:
> The driver depends on CONFIG_OF, so it is not necessary to use CONFIG_OF
> and of_match_ptr() here, we remove them all.
> 
> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it.
> 
> Signed-off-by: Zhu Wang <wangzhu9 at huawei.com>
> Reviewed-by: Arnd Bergmann <arnd at arndb.de>

> Reviewed-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>

I haven't given you any tag, why is this line here?!

-- 
With Best Regards,
Andy Shevchenko




More information about the dri-devel mailing list