[PATCH] drm/tests: Remove CONFIG_DRM_FBDEV_EMULATION on .kunitconfig

[Javier Martinez Canillas]

Javier Martinez Canillas <javierm at redhat.com> writes:

> "Arnd Bergmann" <arnd at arndb.de> writes:
>
> [adding Randy Dunlap who also reported the same issue]
>
> Hello Arnd,
>
>> On Thu, Jul 27, 2023, at 18:45, Javier Martinez Canillas wrote:
>>> Arthur Grillo Queiroz Cabral <arthurgrillo at riseup.net> writes:
>>>> On 27/07/23 13:07, Javier Martinez Canillas wrote:
>>>>> "Arnd Bergmann" <arnd at arndb.de> writes:
>>>>>> Changing the local config should not be required after fixing
>>>>>> the Kconfig files.
>>>>>>
>>>>> 
>>>>> CONFIG_VT can only be disabled if CONFIG_EXPERT=y but I also see that it
>>>>> does not default to 'y' if !UML. Also FRAMEBUFFER_CONSOLE depends on !UML
>>>>> but DRM_FBDEV_EMULATION selects FRAMEBUFFER_CONSOLE if !EXPERT.
>>>>> 
>>>>> Maybe we should include !UML in that condition to? Something like this:
>>>>> 
>>>>> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
>>>>> index 0d499669d653..734332f222ea 100644
>>>>> --- a/drivers/gpu/drm/Kconfig
>>>>> +++ b/drivers/gpu/drm/Kconfig
>>>>> @@ -135,7 +135,7 @@ config DRM_DEBUG_MODESET_LOCK
>>>>>  config DRM_FBDEV_EMULATION
>>>>>         bool "Enable legacy fbdev support for your modesetting driver"
>>>>>         depends on DRM
>>>>> -       select FRAMEBUFFER_CONSOLE if !EXPERT
>>>>> +       select FRAMEBUFFER_CONSOLE if (!EXPERT && !UML)
>>
>> Yes, that should work. Was the original bug report about UML then?
>>
>
> By original do you mean Arthur's report or Randy's? But yes, in both cases
> CONFIG_UML=y when the issue was seen.
>
>> I'm not actually sure we need the select at all. When I tried
>> to narrow down how fbdev is used in the previous
>> thread, the answer was pretty much that it could be used
>> in any possible way, so there might be users that only want
>> the /dev/fb0 interface but not the console, or even just
>> the logo.
>>
>
> Yes, I agree with you. Maybe then the fix could be to just drop that select?
>

I've posted a patch [0] doing this as suggested by Arnd. Let me know what
you think.

[0]: https://lists.freedesktop.org/archives/dri-devel/2023-August/417565.html

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat