[PATCH 1/2] dt-bindings: display: newvision, nv3051d: Add Anbernic 351V Support
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Sat Aug 5 21:14:26 UTC 2023
On 04/08/2023 18:45, Chris Morgan wrote:
> From: Chris Morgan <macromorgan at hotmail.com>
>
> Document the Anbernic RG351V panel, which appears to be identical to
> the panel used in their 353 series except for in inclusion of an
> additional DSI format flag.
>
> Signed-off-by: Chris Morgan <macromorgan at hotmail.com>
> ---
> .../display/panel/newvision,nv3051d.yaml | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml
> index 116c1b6030a2..1226db3613e6 100644
> --- a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml
> @@ -8,8 +8,8 @@ title: NewVision NV3051D based LCD panel
>
> description: |
> The NewVision NV3051D is a driver chip used to drive DSI panels. For now,
> - this driver only supports the 640x480 panels found in the Anbernic RG353
> - based devices.
> + this driver only supports the 640x480 panels found in the Anbernic RG351
> + and 353 based devices.
I would prefer to drop the reference to driver entirely. It's not
related to the bindings. If driver changes (e.g. supports 1024x768),
then binding changes as well?
>
> maintainers:
> - Chris Morgan <macromorgan at hotmail.com>
> @@ -19,11 +19,15 @@ allOf:
>
> properties:
> compatible:
> - items:
> - - enum:
> - - anbernic,rg353p-panel
> - - anbernic,rg353v-panel
> - - const: newvision,nv3051d
> + oneOf:
> + - items:
> + - enum:
> + - anbernic,rg353p-panel
> + - anbernic,rg353v-panel
> + - const: newvision,nv3051d
> +
> + - items:
> + - const: anbernic,rg351v-panel
This part is good, so with adjusting description:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
Best regards,
Krzysztof
More information about the dri-devel
mailing list