[PATCH v5] accel/qaic: tighten integer overflow checking in map_user_pages()
Dan Carpenter
dan.carpenter at linaro.org
Mon Aug 7 14:48:23 UTC 2023
On Mon, Aug 07, 2023 at 05:09:34PM +0300, Dan Carpenter wrote:
> + remaining = in_trans->size - resources->xferred_dma_size;
> + total = in_trans->size + offset_in_page(xfer_start_addr);
> + if (total >= SIZE_MAX)
Btw, I wrote it >= instead of > to silence some idiotic static analysis.
On a 64bit system U64_MAX can't be greater than SIZE_MAX so Gcc will
complain.
However this test only affect 32bit systems and > and >= SIZE_MAX on a
32bit system are effecitively the same. Neither one is ever going to
happen.
regards,
dan carpenter
More information about the dri-devel
mailing list