[PATCH -next 6/7] drm/format-helper: Remove unnecessary NULL values
Ruan Jinjie
ruanjinjie at huawei.com
Wed Aug 9 03:44:44 UTC 2023
The NULL initialization of the pointers assigned by
kunit_kzalloc() first is not necessary, because if kunit_kzalloc()
failed, the pointers will be assigned NULL, otherwise it works
as usual. so remove it.
Signed-off-by: Ruan Jinjie <ruanjinjie at huawei.com>
---
.../gpu/drm/tests/drm_format_helper_test.c | 28 +++++++++----------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c b/drivers/gpu/drm/tests/drm_format_helper_test.c
index 474bb7a1c4ee..1db12d8ed23c 100644
--- a/drivers/gpu/drm/tests/drm_format_helper_test.c
+++ b/drivers/gpu/drm/tests/drm_format_helper_test.c
@@ -452,7 +452,7 @@ static size_t conversion_buf_size(u32 dst_format, unsigned int dst_pitch,
static u16 *le16buf_to_cpu(struct kunit *test, const __le16 *buf, size_t buf_size)
{
- u16 *dst = NULL;
+ u16 *dst;
int n;
dst = kunit_kzalloc(test, sizeof(*dst) * buf_size, GFP_KERNEL);
@@ -467,7 +467,7 @@ static u16 *le16buf_to_cpu(struct kunit *test, const __le16 *buf, size_t buf_siz
static u32 *le32buf_to_cpu(struct kunit *test, const __le32 *buf, size_t buf_size)
{
- u32 *dst = NULL;
+ u32 *dst;
int n;
dst = kunit_kzalloc(test, sizeof(*dst) * buf_size, GFP_KERNEL);
@@ -482,7 +482,7 @@ static u32 *le32buf_to_cpu(struct kunit *test, const __le32 *buf, size_t buf_siz
static __le32 *cpubuf_to_le32(struct kunit *test, const u32 *buf, size_t buf_size)
{
- __le32 *dst = NULL;
+ __le32 *dst;
int n;
dst = kunit_kzalloc(test, sizeof(*dst) * buf_size, GFP_KERNEL);
@@ -509,7 +509,7 @@ static void drm_test_fb_xrgb8888_to_gray8(struct kunit *test)
const struct convert_xrgb8888_case *params = test->param_value;
const struct convert_to_gray8_result *result = ¶ms->gray8_result;
size_t dst_size;
- u8 *buf = NULL;
+ u8 *buf;
__le32 *xrgb8888 = NULL;
struct iosys_map dst, src;
@@ -539,7 +539,7 @@ static void drm_test_fb_xrgb8888_to_rgb332(struct kunit *test)
const struct convert_xrgb8888_case *params = test->param_value;
const struct convert_to_rgb332_result *result = ¶ms->rgb332_result;
size_t dst_size;
- u8 *buf = NULL;
+ u8 *buf;
__le32 *xrgb8888 = NULL;
struct iosys_map dst, src;
@@ -569,7 +569,7 @@ static void drm_test_fb_xrgb8888_to_rgb565(struct kunit *test)
const struct convert_xrgb8888_case *params = test->param_value;
const struct convert_to_rgb565_result *result = ¶ms->rgb565_result;
size_t dst_size;
- u16 *buf = NULL;
+ u16 *buf;
__le32 *xrgb8888 = NULL;
struct iosys_map dst, src;
@@ -605,7 +605,7 @@ static void drm_test_fb_xrgb8888_to_xrgb1555(struct kunit *test)
const struct convert_xrgb8888_case *params = test->param_value;
const struct convert_to_xrgb1555_result *result = ¶ms->xrgb1555_result;
size_t dst_size;
- u16 *buf = NULL;
+ u16 *buf;
__le32 *xrgb8888 = NULL;
struct iosys_map dst, src;
@@ -636,7 +636,7 @@ static void drm_test_fb_xrgb8888_to_argb1555(struct kunit *test)
const struct convert_xrgb8888_case *params = test->param_value;
const struct convert_to_argb1555_result *result = ¶ms->argb1555_result;
size_t dst_size;
- u16 *buf = NULL;
+ u16 *buf;
__le32 *xrgb8888 = NULL;
struct iosys_map dst, src;
@@ -667,7 +667,7 @@ static void drm_test_fb_xrgb8888_to_rgba5551(struct kunit *test)
const struct convert_xrgb8888_case *params = test->param_value;
const struct convert_to_rgba5551_result *result = ¶ms->rgba5551_result;
size_t dst_size;
- u16 *buf = NULL;
+ u16 *buf;
__le32 *xrgb8888 = NULL;
struct iosys_map dst, src;
@@ -698,7 +698,7 @@ static void drm_test_fb_xrgb8888_to_rgb888(struct kunit *test)
const struct convert_xrgb8888_case *params = test->param_value;
const struct convert_to_rgb888_result *result = ¶ms->rgb888_result;
size_t dst_size;
- u8 *buf = NULL;
+ u8 *buf;
__le32 *xrgb8888 = NULL;
struct iosys_map dst, src;
@@ -732,7 +732,7 @@ static void drm_test_fb_xrgb8888_to_argb8888(struct kunit *test)
const struct convert_xrgb8888_case *params = test->param_value;
const struct convert_to_argb8888_result *result = ¶ms->argb8888_result;
size_t dst_size;
- u32 *buf = NULL;
+ u32 *buf;
__le32 *xrgb8888 = NULL;
struct iosys_map dst, src;
@@ -763,7 +763,7 @@ static void drm_test_fb_xrgb8888_to_xrgb2101010(struct kunit *test)
const struct convert_xrgb8888_case *params = test->param_value;
const struct convert_to_xrgb2101010_result *result = ¶ms->xrgb2101010_result;
size_t dst_size;
- u32 *buf = NULL;
+ u32 *buf;
__le32 *xrgb8888 = NULL;
struct iosys_map dst, src;
@@ -794,7 +794,7 @@ static void drm_test_fb_xrgb8888_to_argb2101010(struct kunit *test)
const struct convert_xrgb8888_case *params = test->param_value;
const struct convert_to_argb2101010_result *result = ¶ms->argb2101010_result;
size_t dst_size;
- u32 *buf = NULL;
+ u32 *buf;
__le32 *xrgb8888 = NULL;
struct iosys_map dst, src;
@@ -825,7 +825,7 @@ static void drm_test_fb_xrgb8888_to_mono(struct kunit *test)
const struct convert_xrgb8888_case *params = test->param_value;
const struct convert_to_mono_result *result = ¶ms->mono_result;
size_t dst_size;
- u8 *buf = NULL;
+ u8 *buf;
__le32 *xrgb8888 = NULL;
struct iosys_map dst, src;
--
2.34.1
More information about the dri-devel
mailing list