[PATCH 1/2] drm/panic: Add a drm panic handler
kernel test robot
lkp at intel.com
Thu Aug 10 05:16:21 UTC 2023
Hi Jocelyn,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 6995e2de6891c724bfeb2db33d7b87775f913ad1]
url: https://github.com/intel-lab-lkp/linux/commits/Jocelyn-Falempe/drm-panic-Add-a-drm-panic-handler/20230810-032733
base: 6995e2de6891c724bfeb2db33d7b87775f913ad1
patch link: https://lore.kernel.org/r/20230809192514.158062-2-jfalempe%40redhat.com
patch subject: [PATCH 1/2] drm/panic: Add a drm panic handler
config: nios2-randconfig-r011-20230809 (https://download.01.org/0day-ci/archive/20230810/202308101307.hbEyAamN-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230810/202308101307.hbEyAamN-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308101307.hbEyAamN-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/drm_panic.c:246:6: warning: no previous prototype for 'drm_panic_init_client' [-Wmissing-prototypes]
246 | void drm_panic_init_client(struct drm_device *dev)
| ^~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/drm_panic.c:272:6: warning: no previous prototype for 'drm_panic_init' [-Wmissing-prototypes]
272 | void drm_panic_init(void)
| ^~~~~~~~~~~~~~
>> drivers/gpu/drm/drm_panic.c:282:6: warning: no previous prototype for 'drm_panic_exit' [-Wmissing-prototypes]
282 | void drm_panic_exit(void)
| ^~~~~~~~~~~~~~
--
>> drivers/gpu/drm/drm_panic.c:28: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* This module displays a user friendly message on screen when a kernel panic
drivers/gpu/drm/drm_panic.c:36: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* List of drm clients
>> drivers/gpu/drm/drm_panic.c:283: warning: expecting prototype for drm_log_exit(). Prototype was for drm_panic_exit() instead
vim +/drm_panic_init_client +246 drivers/gpu/drm/drm_panic.c
245
> 246 void drm_panic_init_client(struct drm_device *dev)
247 {
248 struct dpanic_drm_client *new;
249 int ret;
250
251 new = kzalloc(sizeof(*new), GFP_KERNEL);
252 if (!new)
253 return;
254
255 ret = drm_client_init(dev, &new->client, "drm_panic", NULL);
256 if (ret < 0) {
257 kfree(new);
258 return;
259 }
260 drm_client_register(&new->client);
261 list_add_tail(&new->head, &dpanic_clients);
262
263 drm_info(dev, "Registered with drm panic\n");
264 }
265 EXPORT_SYMBOL(drm_panic_init_client);
266
267 /**
268 * drm_panic_init() - Initialize drm-panic subsystem
269 *
270 * register the panic notifier
271 */
> 272 void drm_panic_init(void)
273 {
274 /* register panic handler */
275 atomic_notifier_chain_register(&panic_notifier_list,
276 &drm_panic_notifier);
277 }
278
279 /**
280 * drm_log_exit() - Shutdown drm-panic subsystem
281 */
> 282 void drm_panic_exit(void)
> 283 {
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the dri-devel
mailing list