[PATCH v2 13/15] drm/panthor: Allow driver compilation

[Daniel Stone]

Hi,

On 11/08/2023 17:35, Robin Murphy wrote:
> On 2023-08-09 17:53, Boris Brezillon wrote:
>> +obj-$(CONFIG_DRM_PANTHOR) += panthor.o
>
> FWIW I still think it would be nice to have a minor 
> directory/Kconfig/Makefile reshuffle and a trivial bit of extra 
> registration glue to build both drivers into a single module. It seems 
> like it could be a perpetual source of confusion to end users where 
> Mesa "panfrost" is the right option but kernel "panfrost" is the wrong 
> one. Especially when pretty much every other GPU driver is also just 
> one big top-level module to load for many different generations of 
> hardware. Plus it would mean that if someone did want to have a go at 
> deduplicating the resource-wrangling boilerplate for OPPs etc. in 
> future, there's more chance of being able to do so meaningfully.

It might be nice to point it out, but to be fair Intel and AMD both have 
two (or more) drivers, as does Broadcom/RPi. As does, err ... Mali.

I can see the point, but otoh if someone's managed to build all the 
right regulator/clock/etc modules to get a working system, they'll 
probably manage to figure teh GPU side out?

Cheers,

Daniel