[PATCH v2 1/2] pwm: Manage owner assignment implicitly for drivers

[Neil Armstrong]

On 04/08/2023 16:27, Uwe Kleine-König wrote:
> Instead of requiring each driver to care for assigning the owner member
> of struct pwm_ops, handle that implicitly using a macro. Note that the
> owner member has to be moved to struct pwm_chip, as the ops structure
> usually lives in read-only memory and so cannot be modified.
> 
> The upside is that new lowlevel drivers cannot forget the assignment and
> save one line each. The pwm-crc driver didn't assign .owner, that's not
> a problem in practise though as the driver cannot be compiled as a
> module.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
>   drivers/gpio/gpio-mvebu.c             |  1 -
>   drivers/gpu/drm/bridge/ti-sn65dsi86.c |  1 -
>   drivers/leds/rgb/leds-qcom-lpg.c      |  1 -
>   drivers/pwm/core.c                    | 24 ++++++++++++++----------
>   drivers/pwm/pwm-ab8500.c              |  1 -
>   drivers/pwm/pwm-apple.c               |  1 -
>   drivers/pwm/pwm-atmel-hlcdc.c         |  1 -
>   drivers/pwm/pwm-atmel-tcb.c           |  1 -
>   drivers/pwm/pwm-atmel.c               |  1 -
>   drivers/pwm/pwm-bcm-iproc.c           |  1 -
>   drivers/pwm/pwm-bcm-kona.c            |  1 -
>   drivers/pwm/pwm-bcm2835.c             |  1 -
>   drivers/pwm/pwm-berlin.c              |  1 -
>   drivers/pwm/pwm-brcmstb.c             |  1 -
>   drivers/pwm/pwm-clk.c                 |  1 -
>   drivers/pwm/pwm-clps711x.c            |  1 -
>   drivers/pwm/pwm-cros-ec.c             |  1 -
>   drivers/pwm/pwm-dwc.c                 |  1 -
>   drivers/pwm/pwm-ep93xx.c              |  1 -
>   drivers/pwm/pwm-fsl-ftm.c             |  1 -
>   drivers/pwm/pwm-hibvt.c               |  1 -
>   drivers/pwm/pwm-img.c                 |  1 -
>   drivers/pwm/pwm-imx-tpm.c             |  1 -
>   drivers/pwm/pwm-imx1.c                |  1 -
>   drivers/pwm/pwm-imx27.c               |  1 -
>   drivers/pwm/pwm-intel-lgm.c           |  1 -
>   drivers/pwm/pwm-iqs620a.c             |  1 -
>   drivers/pwm/pwm-jz4740.c              |  1 -
>   drivers/pwm/pwm-keembay.c             |  1 -
>   drivers/pwm/pwm-lp3943.c              |  1 -
>   drivers/pwm/pwm-lpc18xx-sct.c         |  1 -
>   drivers/pwm/pwm-lpc32xx.c             |  1 -
>   drivers/pwm/pwm-lpss.c                |  1 -
>   drivers/pwm/pwm-mediatek.c            |  1 -
>   drivers/pwm/pwm-meson.c               |  1 -

Acked-by: Neil Armstrong <neil.armstrong at linaro.org> # pwm-meson

>   drivers/pwm/pwm-microchip-core.c      |  1 -
>   drivers/pwm/pwm-mtk-disp.c            |  1 -
>   drivers/pwm/pwm-mxs.c                 |  1 -
>   drivers/pwm/pwm-ntxec.c               |  1 -
>   drivers/pwm/pwm-omap-dmtimer.c        |  1 -
>   drivers/pwm/pwm-pca9685.c             |  1 -
>   drivers/pwm/pwm-pxa.c                 |  1 -
>   drivers/pwm/pwm-raspberrypi-poe.c     |  1 -
>   drivers/pwm/pwm-rcar.c                |  1 -
>   drivers/pwm/pwm-renesas-tpu.c         |  1 -
>   drivers/pwm/pwm-rockchip.c            |  1 -
>   drivers/pwm/pwm-rz-mtu3.c             |  1 -
>   drivers/pwm/pwm-samsung.c             |  1 -
>   drivers/pwm/pwm-sifive.c              |  1 -
>   drivers/pwm/pwm-sl28cpld.c            |  1 -
>   drivers/pwm/pwm-spear.c               |  1 -
>   drivers/pwm/pwm-sprd.c                |  1 -
>   drivers/pwm/pwm-sti.c                 |  1 -
>   drivers/pwm/pwm-stm32-lp.c            |  1 -
>   drivers/pwm/pwm-stm32.c               |  1 -
>   drivers/pwm/pwm-stmpe.c               |  1 -
>   drivers/pwm/pwm-sun4i.c               |  1 -
>   drivers/pwm/pwm-sunplus.c             |  1 -
>   drivers/pwm/pwm-tegra.c               |  1 -
>   drivers/pwm/pwm-tiecap.c              |  1 -
>   drivers/pwm/pwm-tiehrpwm.c            |  1 -
>   drivers/pwm/pwm-twl-led.c             |  2 --
>   drivers/pwm/pwm-twl.c                 |  2 --
>   drivers/pwm/pwm-visconti.c            |  1 -
>   drivers/pwm/pwm-vt8500.c              |  1 -
>   drivers/pwm/pwm-xilinx.c              |  1 -
>   drivers/staging/greybus/pwm.c         |  1 -
>   include/linux/pwm.h                   | 10 ++++++----
>   68 files changed, 20 insertions(+), 82 deletions(-)
> 

<snip>

> diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
> index 25519cddc2a9..5bea53243ed2 100644
> --- a/drivers/pwm/pwm-meson.c
> +++ b/drivers/pwm/pwm-meson.c
> @@ -335,7 +335,6 @@ static const struct pwm_ops meson_pwm_ops = {
>   	.free = meson_pwm_free,
>   	.apply = meson_pwm_apply,
>   	.get_state = meson_pwm_get_state,
> -	.owner = THIS_MODULE,
>   };
>   
>   static const char * const pwm_meson8b_parent_names[] = {

<snip>